Add sextend_maybe and uextend_maybe to opt ISLE#7710
Merged
Conversation
github-actions
Bot
added
cranelift
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on something else, I noticed that the
(x < y) != 0opt was written in a way that only works for Cwasmtime/cranelift/codegen/src/opts/icmp.isle
Lines 16 to 25 in f8c9f67
whereas in Rust, which doesn't have the "usual arithmetic conversions", the result of the comparison stays as
I8and thus without the extension it didn't match that pattern.This picks up a suggestion that alex had made in a previous PR (#7636 (comment)) to make something like lowering ISLE's
maybe_uextendextractor for optimization ISLE.They're then used to improve the mentioned icmp-of-icmp pattern
8ef0b81#diff-fa420f878e321dc6579ac911f9ba8820a9381e4c49615584f6e6909f0e329dfcL124-R125
as well as simplify some of the duplication in the
<=>patterns.